Browse Source

ui: Check last played datetime validity against current culture (#1730)

This is an issue happening when you change your datetime format on your
system and try to sort via last played datetime. DateTime.Parse use the
current thread culture and will not parse date correctly, effectively
causing a crash.

As such, I added a check when loading the game list that ensure that the
datetime is valid in current culture.

Fix #1727.
Mary 5 năm trước cách đây
mục cha
commit
245f8a7eee
1 tập tin đã thay đổi với 7 bổ sung0 xóa
  1. 7 0
      Ryujinx/Ui/ApplicationLibrary.cs

+ 7 - 0
Ryujinx/Ui/ApplicationLibrary.cs

@@ -390,6 +390,13 @@ namespace Ryujinx.Ui
 
 
                 ApplicationMetadata appMetadata = LoadAndSaveMetaData(titleId);
                 ApplicationMetadata appMetadata = LoadAndSaveMetaData(titleId);
 
 
+                if (appMetadata.LastPlayed != "Never" && !DateTime.TryParse(appMetadata.LastPlayed, out _))
+                {
+                    Logger.Warning?.Print(LogClass.Application, $"Last played datetime \"{appMetadata.LastPlayed}\" is invalid for current system culture, skipping (did current culture change?)");
+
+                    appMetadata.LastPlayed = "Never";
+                }
+
                 ApplicationData data = new ApplicationData
                 ApplicationData data = new ApplicationData
                 {
                 {
                     Favorite      = appMetadata.Favorite,
                     Favorite      = appMetadata.Favorite,